[Bug 2130552] Re: i40e driver is triggering VF resets on every link state change

This bug is awaiting verification that the linux-
oracle-6.17/6.17.0-1007.7~24.04.1 kernel in -proposed solves the
problem. Please test the kernel and update this bug with the results. If
the problem is solved, change the tag 'verification-needed-noble-linux-
oracle-6.17' to 'verification-done-noble-linux-oracle-6.17'. If the
problem still exists, change the tag 'verification-needed-noble-linux-
oracle-6.17' to 'verification-failed-noble-linux-oracle-6.17'.


If verification is not done by 5 working days from today, this fix will
be dropped from the source code, and this bug will be closed.


See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how
to enable and use -proposed. Thank you!


** Tags added: kernel-spammed-noble-linux-oracle-6.17-v2 verification-needed-noble-linux-oracle-6.17

--
You received this bug notification because you are subscribed to linux
in Ubuntu.
Matching subscriptions: Bgg, Bmail, Nb
https://bugs.launchpad.net/bugs/2130552

Title:
i40e driver is triggering VF resets on every link state change

Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Jammy:
Fix Released
Status in linux source package in Noble:
Fix Released
Status in linux source package in Plucky:
Fix Released
Status in linux source package in Questing:
Fix Released
Status in linux source package in Resolute:
Fix Released

Bug description:
[ Impact ]

* In the i40e driver, every VF link state change request is causing a VF reset,
even if the requested change is already set. This leads to unnecessary VF
resets and can cause performance degradation or instability in the VF
driver, particularly in DPDK environments.

* With the proposed patch, i40e will skip VF link state change requests when the
desired link state matches the current configuration. This prevents
unnecessary VF resets and reduces PF-VF communication overhead.

* The issue was originally detected by analyzing DPDK VF driver issues during
OpenStack Neutron restarts. In such cases, i40e will issue an unnecessary VF
reset request which causes instability in the DPDK driver.


[ Test Plan ]

* The issue can be reproduced by triggering VF link state changes multiple times
with the same requested link state.

* To reproduce the problem, run the following command multiple times
on the same interface: 'ip link set <ifname> vf 0 state auto'.
Every time the command is executed, the PF driver will trigger a VF reset.

* Monitor for VF reset events using dmesg or appropriate logging mechanisms
to confirm the issue and verify the fix.

* Regression testing should include:
- Verify normal VF link state changes still work correctly when state actually changes
- Validate that legitimate state changes still trigger resets when needed

[ Where problems could occur ]

* Changes only affect the i40e .ndo_set_vf_link_state routine. In case
of any regressions, only the ability to set VF link state changes could be
impacted.

* The patch was verified locally and passed Intel internal test
execution.

* Potential failure modes:
- Logic error in state comparison could prevent legitimate state changes
- Incorrect state tracking could lead to inconsistent VF behavior

* Risk mitigation:
- The change is isolated to a specific code path in the i40e driver
- Existing VF functionality remains unchanged when state changes are needed
- The patch adds a simple comparison check before existing link change routine

[ Other Info ]

* At the time of writing this document, the target patch is still in the net-next
tree and has not yet been merged into mainline.

* Patch: a7ae783da0b919550e260aebfca1c6ef030b99a4 from netdev/net-
next

* Patch applies on most versions without any conflicts

* No dependencies on other patches

* Mainline status: Patch is currently in net-next tree, awaiting mainline merge

* Backport requirements: Patch should apply cleanly to Ubuntu kernel versions

* VF reset during link state change was added as a part of
31deb12e85c35ddd2c037f0107d05d8674cab2c0 (upstream) commit, which is
included in the Kernels starting from 5.15

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2130552/+subscriptions