[Bug 2128792] Re: Re-enable INTEL_SKL_INT3472 for kernels >= 6.16 for Intel IPU camera

Verified linux-oem-6.17/6.17.0-1006.6.

** Tags removed: verification-needed-noble-linux-oem-6.17
** Tags added: verification-done-noble-linux-oem-6.17

--
You received this bug notification because you are subscribed to linux
in Ubuntu.
Matching subscriptions: Bgg, Bmail, Nb
https://bugs.launchpad.net/bugs/2128792

Title:
Re-enable INTEL_SKL_INT3472 for kernels >= 6.16 for Intel IPU camera

Status in linux package in Ubuntu:
In Progress
Status in linux-oem-6.17 package in Ubuntu:
Invalid
Status in linux source package in Noble:
Invalid
Status in linux-oem-6.17 source package in Noble:
Fix Committed
Status in linux source package in Questing:
In Progress
Status in linux-oem-6.17 source package in Questing:
Invalid
Status in linux source package in Resolute:
In Progress
Status in linux-oem-6.17 source package in Resolute:
Invalid

Bug description:
[ SRU Justification ]

BugLink: https://bugs.launchpad.net/bugs/2128792

[ Impact ]

INTEL_SKL_INT3472 was wrongly disabled to fix build error due to
duplicated switch case INT3472_GPIO_TYPE_HANDSHAKE at porting linux-
unstable-6.16 in Ubuntu kernel commit e5a18620b838 ("UBUNTU: [Config]
FTBFS: disable INTEL_SKL_INT3472"). The root cause is the Ubuntu
sauced commit 9672bb65ed17 ("UBUNTU: SAUCE: platform/x86: int3472: Add
handshake GPIO function") has been upstreamed as v6.16-rc1 commit
c5d0393272048 ("platform/x86: int3472: Add handshake pin support").
Therefore both commit e5a18620b838 and commit 9672bb65ed17 should be
reverted.

INTEL_SKL_INT3472 support is mandatory for Intel IPU6/IPU7 per
https://github.com/intel/ipu6-drivers/blob/master/README.md#dependencies
. Without it the camera sensor driver may not be able to finish its
probe.

```
# No device found so no "device-name" property.
$ sudo gst-inspect-1.0 icamerasrc
......
Element Properties:
......
```

[ Test Plan ]

1. Install kernels from proposed pocket:
```
$ sudo apt-get install --no-install-recommends --yes \
linux-oem-24.04d \
linux-modules-ipu6-oem-24.04d \
linux-modules-ipu7-oem-24.04d \
linux-modules-usbio-oem-24.04d \
linux-modules-vision-oem-24.04d
```

2. Install IPU packages from OEM PPA:
```
$ sudo add-apt-repository ppa:oem-solutions-group/intel-ipu6
$ sudo add-apt-repository ppa:oem-solutions-group/intel-ipu7
$ sudo apt-get install --no-install-recommends --yes \
gstreamer1.0-icamera \
libcamhal-ipu6 \
libcamhal-ipu6ep \
libcamhal-ipu6epmtl \
libcamhal-ipu7x \
libcamhal-ipu75xa \
v4.2-relayd
```

3. Reboot into installed kernel.

4. Check if camera sensor finishes its probing. With fix it should have:
```
kernel: intel-ipu7 intel-ipu7: Found supported sensor OVTI13B1:01
kernel: ov13b10 i2c-OVTI13B1:01: 2 lanes with 1 modes selected
kernel: ov13b10 i2c-OVTI13B1:01: Instantiated dw9714 VCM
kernel: dw9714 i2c-OVTI13B1:01-VCM: supply vcc not found, using dummy regulator
```
And without:
```
kernel: intel-ipu7 intel-ipu7: Found supported sensor OVTI13B1:01
```

5. Check if camera sensor appears in `gst-inspect-1.0 icamerasrc` output:
```
$ sudo gst-inspect-1.0 icamerasrc
......
Element Properties:
......
device-name : The input devices name queried from HAL
flags: readable, writable
Enum "GstCamerasrcDeviceName" Default: 0, "ov13b10-uf"
(0): ov13b10-uf - ov13b10 as sensor.
```

[ Where problems could occur ]

This restores INTEL_SKL_INT3472 that has been included long ago
(v4.15?).

[ Other Info ]

While this affects all Ubuntu kernels >= 6.16, nominate linux-
oem-6.17/noble, linux/questing, linux-unstable/resolute for fix.

========== original bug report ==========

INTEL_SKL_INT3472 was wrongly disabled to fix build error due to
duplicated switch case INT3472_GPIO_TYPE_HANDSHAKE at porting linux-
unstable-6.16 in Ubuntu kernel commit e5a18620b838 ("UBUNTU: [Config]
FTBFS: disable INTEL_SKL_INT3472"). The root cause is the Ubuntu
sauced commit 9672bb65ed17 ("UBUNTU: SAUCE: platform/x86: int3472: Add
handshake GPIO function") has been upstreamed as v6.16-rc1 commit
c5d0393272048 ("platform/x86: int3472: Add handshake pin support").
Therefore both commit e5a18620b838 and commit 9672bb65ed17 should be
reverted.

INTEL_SKL_INT3472 support is mandatory for Intel IPU6/IPU7 per
https://github.com/intel/ipu6-drivers/blob/master/README.md#dependencies
.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2128792/+subscriptions