[Bug 2042546] Re: Include cifs.ko in linux-modules package

This bug is awaiting verification that the linux-
nvidia-6.8/6.8.0-1008.8~22.04.1 kernel in -proposed solves the problem.
Please test the kernel and update this bug with the results. If the
problem is solved, change the tag 'verification-needed-jammy-linux-
nvidia-6.8' to 'verification-done-jammy-linux-nvidia-6.8'. If the
problem still exists, change the tag 'verification-needed-jammy-linux-
nvidia-6.8' to 'verification-failed-jammy-linux-nvidia-6.8'.


If verification is not done by 5 working days from today, this fix will
be dropped from the source code, and this bug will be closed.


See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how
to enable and use -proposed. Thank you!


** Tags added: kernel-spammed-jammy-linux-nvidia-6.8-v2 verification-needed-jammy-linux-nvidia-6.8

--
You received this bug notification because you are subscribed to linux
in Ubuntu.
Matching subscriptions: Bgg, Bmail, Nb
https://bugs.launchpad.net/bugs/2042546

Title:
Include cifs.ko in linux-modules package

Status in linux package in Ubuntu:
Fix Committed
Status in linux source package in Lunar:
Fix Released
Status in linux source package in Mantic:
Fix Committed
Status in linux source package in Noble:
Fix Released

Bug description:
[Impact]

Commit: "smb: move client and server files to common directory fs/smb" moved the fs/cifs directory to fs/sb/client. The inclusion list for linux-modules was not updated, it still contains the old path. This means that the cifs.ko module cannot be loaded if only linux-modules package is installed, now being part of linux-modules-extra.
For the main kernels this is not a problem because linux-modules-extra is always installed, but for derivatives like aws, azure etc, this module cannot be loaded without explicitly installing linux-modules-extra.

[How to reproduce it]:
1. Install the latest azure kernel 6.5.0-1017.17
2. Load cifs module
$ modprobe cifs
modprobe: FATAL: Module cifs not found in directory /lib/modules/6.5.0-1017-azure
If modules-extra is installed, this works.

[Fix]

Replace fs/cifs/* with fs/smb/client/* in
debian.<derivative>/control.d/<derivative>.inclusion-list. First the
main kernels are addressed, derivatives will be fixed via cranky fix.

[Test Plan]

1. Apply the fix to one of the derivative (azure), build a new kernel and install it
2. Load cifs module
$ modprobe cifs
It should work without installing modules-extra.

[Regression potential]

Very low, it's a straightforward fix.

[Other Info]
Sending a patch for every derivative takes time and each derivative will be fixed once this proposal is acked via cranky fix.

Original for lunar only
SRU Justification:

[Impact]

Commit: "smb: move client and server files to common directory fs/smb" introduced in 2023.09.04 moved the fs/cifs directory to fs/sb/client. The inclusion list for linux-modules was not updated, it still contains the old path. This means that the cifs.ko module cannot be loaded if only linux-modules package is installed, now being part of linux-modules-extra.
For lunar:main this is not a problem because linux-modules-extra is always installed, but for derivatives like aws, azure etc, this module cannot be loaded without explicitly installing linux-modules-extra.

[How to reproduce it]:
1. Install the latest azure kernel 6.2.0-1016.16
2. Load cifs module
$ modprobe cifs
modprobe: FATAL: Module cifs not found in directory /lib/modules/6.2.0-1016-azure
If modules-extra is installed, this works.

[Fix]

Replace fs/cifs/* with fs/smb/client/* in debian.<derivative>/control.d/<derivative>.inclusiojn-list
This is going to be done in s2023.10.02 cycle for derivatives.

[Test Plan]

1. Apply the fix to one of the derivative (azure), build a new kernel and install it
2. Load cifs module
$ modprobe cifs
It should work without installing modules-extra.

[Regression potential]

Very low, it's a straightforward fix.

[Other Info]
Sending a patch for every derivative takes time and each derivative will be fixed once this proposal is acked.
There is also the possibility to do it via cranky fix, but owners may omit it during security updates and it's hard to enforce it. Plus, it is a one-time change.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2042546/+subscriptions