[Bug 1928788] Re: linux-azure: Add Mana network driver

This bug was fixed in the package linux-azure - 5.4.0-1051.53

---------------
linux-azure (5.4.0-1051.53) focal; urgency=medium

[ Ubuntu: 5.4.0-77.86 ]

* UAF on CAN J1939 j1939_can_recv (LP: #1932209)
- SAUCE: can: j1939: delay release of j1939_priv after synchronize_rcu
* UAF on CAN BCM bcm_rx_handler (LP: #1931855)
- SAUCE: can: bcm: delay release of struct bcm_op after synchronize_rcu

[ Ubuntu: 5.4.0-76.85 ]

* focal/linux: 5.4.0-76.85 -proposed tracker (LP: #1932123)
* Upstream v5.9 introduced 'module' patches that removed exported symbols
(LP: #1932065)
- SAUCE: Revert "modules: inherit TAINT_PROPRIETARY_MODULE"
- SAUCE: Revert "modules: return licensing information from find_symbol"
- SAUCE: Revert "modules: rename the licence field in struct symsearch to
license"
- SAUCE: Revert "modules: unexport __module_address"
- SAUCE: Revert "modules: unexport __module_text_address"
- SAUCE: Revert "modules: mark each_symbol_section static"
- SAUCE: Revert "modules: mark find_symbol static"
- SAUCE: Revert "modules: mark ref_module static"

-- Stefan Bader <stefan.bader@canonical.com> Thu, 17 Jun 2021 19:43:15
+0200

** Changed in: linux-azure-5.8 (Ubuntu Focal)
Status: In Progress => Fix Released

--
You received this bug notification because you are subscribed to linux
in Ubuntu.
Matching subscriptions: Bgg, Bmail, Nb
https://bugs.launchpad.net/bugs/1928788

Title:
linux-azure: Add Mana network driver

Status in linux package in Ubuntu:
Fix Released
Status in linux-azure package in Ubuntu:
Fix Released
Status in linux-azure-5.8 package in Ubuntu:
Invalid
Status in linux source package in Focal:
Invalid
Status in linux-azure source package in Focal:
Fix Released
Status in linux-azure-5.8 source package in Focal:
Fix Released
Status in linux source package in Groovy:
Invalid
Status in linux-azure source package in Groovy:
Fix Released
Status in linux-azure-5.8 source package in Groovy:
Invalid

Bug description:
SRU Justification

[Impact]

Microsoft has requested the addition of the "mana" driver from Linux v5.11
https://canonical.my.salesforce.com/5004K000005pZQCQA2

[Fix]

This patch set consists of 5 patches that are now in mainline.

The patches add the VF driver for Microsoft Azure Network Adapter
(MANA), and also changes the hv_netvsc driver's netvsc/VF binding
logic to check both the MAC address and the serial number (this is
required by the MANA VF driver).

Microsoft would like to request the following 5 patches in all
supported releases:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=64ff412ad41fe3a5bf759ff4844dc1382176485c

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-
next.git/commit/?id=ca9c54d2d6a5ab2430c4eda364c77125d62e5e0f

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-
next.git/commit/?id=55cdc26a91ac270887583945aef2bd460a2805f7

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-
next.git/commit/?id=45b102dd81491e30ac7596b5515856141f99319f

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-
next.git/commit/?id=d90a94680bc0a8069d93282bc5f2966d00b9c4a4

[Test Plan]

2021-05-17 15:25 UTC-
-We tested the two versions of mana.ko:

root@decui-u2004-vf:~# uname -a
Linux decui-u2004-vf 5.4.0-1048-azure #50~sf00310147.1-Ubuntu SMP Tue May 11 02:06:24 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
root@decui-u2004-vf:~# modinfo mana | grep filename
filename: /lib/modules/5.4.0-1048-azure/kernel/drivers/net/ethernet/microsoft/mana/mana.ko

root@decui-u2004-vf:~# uname -a
Linux decui-u2004-vf 5.8.0-1032-azure #34~SF00310147.1-Ubuntu SMP Tue May 11 02:01:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
root@decui-u2004-vf:~# modinfo mana | grep filename
filename: /lib/modules/5.8.0-1032-azure/kernel/drivers/net/ethernet/microsoft/mana/mana.ko

Everything worked as expected in our testing:
1. The MANA driver loads and unloads multiple times without any issue.
2. iperf TX/RX tests run without any issue, and the performance numbers are on par with what we get with the latest mainline kernel: the TX number is pretty good; the RX number is sometimes not great but this is a known issue with the latest mainline kernel as well.
3. "ethtool -S" and "ethtool -L" work as expected.
4. When iperf TX/RX tests are running, changing the number of the MANA NIC TX/RX queues and unloading/reloading the MANA driver work without any issue.

[Where problems could occur]

The driver may have bug(s) that cause a kernel crash.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1928788/+subscriptions