[Bug 1881710] Autopkgtest regression report (linux-oracle-5.4/5.4.0-1019.19~18.04.1)

All autopkgtests for the newly accepted linux-oracle-5.4 (5.4.0-1019.19~18.04.1) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:

zfs-linux/unknown (armhf)


Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-
migration/bionic/update_excuses.html#linux-oracle-5.4

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

--
You received this bug notification because you are subscribed to linux
in Ubuntu.
Matching subscriptions: Bgg, Bmail, Nb
https://bugs.launchpad.net/bugs/1881710

Title:
tpm: fix TIS locality timeout problems

Status in linux package in Ubuntu:
Invalid
Status in linux-oem-5.6 package in Ubuntu:
Invalid
Status in linux-oem-osp1 package in Ubuntu:
Invalid
Status in linux-oem-osp1 source package in Bionic:
Fix Committed
Status in linux source package in Focal:
Fix Committed
Status in linux-oem-5.6 source package in Focal:
Fix Committed

Bug description:
[Impact]
It has been reported that some TIS based TPMs are giving unexpected errors when using the O_NONBLOCK path of the TPM device. The problem is that some TPMs don't like it when you get and then relinquish a locality (as the tpm_try_get_ops()/tpm_put_ops() pair does) without sending a command. This currently happens all the time in the O_NONBLOCK write path. This affects Nuvoton TPMs and was a regression caused by the patch d23d12484307 ("tpm: fix invalid locking in NONBLOCKING mode").
PatchLink: https://patchwork.kernel.org/patch/11576453/

[Fix]
Fix this by moving the tpm_try_get_ops()
further down the code to after the O_NONBLOCK determination is made.
This is safe because the priv->buffer_mutex still protects the priv
state being modified.

[Regression Risk]
Low. This patch only for fix the patch d23d12484307 ("tpm: fix invalid locking in NONBLOCKING mode").

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1881710/+subscriptions