[Bug 1813869] [NEW] Redpine: Driver crash with network-manager 1.10 and above

Public bug reported:

SRU Justification:
------------------

Impact:
-------
Kernel crash upon inserting Redpine driver

Test case:
----------
1) Install network-manager v(1.10) snap.
2) Insert Redpine modules.
3) Observe the behavior.

Result:
-------
Redpine driver crashes the entire kernel and below is the crash log.
... skipping ...
[ 49.130185] BUG: unable to handle kernel NULL pointer dereference at 0000000000000134
[ 49.138969] IP: [<ffffffffc0517c03>] rsi_prepare_mgmt_desc+0xd3/0x2d0 [ven_rsi_91x]
[ 49.244030] CPU: 0 PID: 31 Comm: kworker/u4:1 Not tainted 4.4.0-139-generic #165-Ubuntu
[ 49.252988] Hardware name: Dell Inc. Edge Gateway 3001/, BIOS 01.00.00 04/17/2017
[ 49.261374] Workqueue: rsi_scan_worker rsi_scan_start [ven_rsi_91x]
[ 49.268385] task: ffff880078538cc0 ti: ffff8800785e4000 task.ti: ffff8800785e4000
[ 49.276765] rsi_prepare_mgmt_desc+0xd3/0x2d0 [ven_rsi_91x]
[ 49.387307] [<ffffffffc0516457>] rsi_send_probe_request+0x2c7/0x350 [ven_rsi_91x]
[ 49.395784] [<ffffffffc0516702>] rsi_scan_start+0x222/0x380 [ven_rsi_91x]
[ 49.403486] [<ffffffff818530c1>] ? __schedule+0x301/0x7f0
[ 49.409633] [<ffffffff8109ee4b>] process_one_work+0x16b/0x490
[ 49.416164] [<ffffffff8109f1bb>] worker_thread+0x4b/0x4d0
[ 49.422306] [<ffffffff8109f170>] ? process_one_work+0x490/0x490
[ 49.429032] [<ffffffff810a5587>] kthread+0xe7/0x100
[ 49.434589] [<ffffffff818530c1>] ? __schedule+0x301/0x7f0
[ 49.440731] [<ffffffff810a54a0>] ? kthread_create_on_node+0x1e0/0x1e0
[ 49.448042] [<ffffffff81857bf5>] ret_from_fork+0x55/0x80
[ 49.454086] [<ffffffff810a54a0>] ? kthread_create_on_node+0x1e0/0x1e0

Root cause analysis:
--------------------
In nm-1.10 and above versions, MAC spoof is enabled by default. In Redpine
driver, this handling is missed. Hence, Added the fix for the same.

Fix:
----
Copied the Custom MAC address into driver global structure.

Regression Petential:
---------------------
This is a very direct issue Since the driver is crashing upon inserting the
modules. we ran the multiple times insertion and deletion of modules and connected
to third-party AP, did data transfer.

** Affects: linux (Ubuntu)
Importance: Undecided
Status: Incomplete


** Tags: xenial

--
You received this bug notification because you are subscribed to linux
in Ubuntu.
Matching subscriptions: Bgg, Bmail, Nb
https://bugs.launchpad.net/bugs/1813869

Title:
Redpine: Driver crash with network-manager 1.10 and above

Status in linux package in Ubuntu:
Incomplete

Bug description:
SRU Justification:
------------------

Impact:
-------
Kernel crash upon inserting Redpine driver

Test case:
----------
1) Install network-manager v(1.10) snap.
2) Insert Redpine modules.
3) Observe the behavior.

Result:
-------
Redpine driver crashes the entire kernel and below is the crash log.
... skipping ...
[ 49.130185] BUG: unable to handle kernel NULL pointer dereference at 0000000000000134
[ 49.138969] IP: [<ffffffffc0517c03>] rsi_prepare_mgmt_desc+0xd3/0x2d0 [ven_rsi_91x]
[ 49.244030] CPU: 0 PID: 31 Comm: kworker/u4:1 Not tainted 4.4.0-139-generic #165-Ubuntu
[ 49.252988] Hardware name: Dell Inc. Edge Gateway 3001/, BIOS 01.00.00 04/17/2017
[ 49.261374] Workqueue: rsi_scan_worker rsi_scan_start [ven_rsi_91x]
[ 49.268385] task: ffff880078538cc0 ti: ffff8800785e4000 task.ti: ffff8800785e4000
[ 49.276765] rsi_prepare_mgmt_desc+0xd3/0x2d0 [ven_rsi_91x]
[ 49.387307] [<ffffffffc0516457>] rsi_send_probe_request+0x2c7/0x350 [ven_rsi_91x]
[ 49.395784] [<ffffffffc0516702>] rsi_scan_start+0x222/0x380 [ven_rsi_91x]
[ 49.403486] [<ffffffff818530c1>] ? __schedule+0x301/0x7f0
[ 49.409633] [<ffffffff8109ee4b>] process_one_work+0x16b/0x490
[ 49.416164] [<ffffffff8109f1bb>] worker_thread+0x4b/0x4d0
[ 49.422306] [<ffffffff8109f170>] ? process_one_work+0x490/0x490
[ 49.429032] [<ffffffff810a5587>] kthread+0xe7/0x100
[ 49.434589] [<ffffffff818530c1>] ? __schedule+0x301/0x7f0
[ 49.440731] [<ffffffff810a54a0>] ? kthread_create_on_node+0x1e0/0x1e0
[ 49.448042] [<ffffffff81857bf5>] ret_from_fork+0x55/0x80
[ 49.454086] [<ffffffff810a54a0>] ? kthread_create_on_node+0x1e0/0x1e0

Root cause analysis:
--------------------
In nm-1.10 and above versions, MAC spoof is enabled by default. In Redpine
driver, this handling is missed. Hence, Added the fix for the same.

Fix:
----
Copied the Custom MAC address into driver global structure.

Regression Petential:
---------------------
This is a very direct issue Since the driver is crashing upon inserting the
modules. we ran the multiple times insertion and deletion of modules and connected
to third-party AP, did data transfer.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1813869/+subscriptions