[Bug 1807411] [NEW] VLAN stripping function will be called after running "ethtool -K rx off" to change the rx checksum setting

Private bug reported:

check the ftrace ,it shows VLAN stripping setting was changed

Description of problem:
When running "ethtool –K rx off" for VF, the i40evf will also change the VLAN stripping setting unexpectedly.
We tried to create a VF on Ubuntu18.04.1 in-tree i40e driver then ran "ethtool -K rx off" for it with the in-tree i40evf driver. The ftrace showed as below:

i40evf_set_features [i40evf] -----> i40evf_enable_vlan_stripping
[i40evf]-----> i40e_vlan_stripping_enable [i40e].

Version-Release number of selected component (if applicable):
RHEL7.6 Alpha kernel: 3.10.0-924.el7.x86_64
i40e driver: 2.1.14-k
i40evf driver: 3.0.1-k
ethtool version 4.15

repro steps and logs:

root@unassigned-hostname:~# echo i40evf_set_features >> /sys/kernel/debug/tracing/set_graph_function
root@unassigned-hostname:~# echo i40evf_enable_vlan_stripping >> /sys/kernel/debug/tracing/set_graph_function
root@unassigned-hostname:~# echo 20 > /sys/kernel/debug/tracing/max_graph_depth
root@unassigned-hostname:~# echo function_graph > /sys/kernel/debug/tracing/current_tracer
root@unassigned-hostname:~# echo 1 > /sys/kernel/debug/tracing/tracing_on
root@unassigned-hostname:~# cat /sys/kernel/debug/tracing/trace # tracer: function_graph #
# CPU DURATION FUNCTION CALLS
# | | | | | | |
root@unassigned-hostname:~# ethtool -K enp175s2 rx off root@unassigned-hostname:~# cat /sys/kernel/debug/tracing/trace # tracer: function_graph #
# CPU DURATION FUNCTION CALLS
# | | | | | | |
60) 0.254 us | i40evf_set_features [i40evf]();
20) | i40evf_enable_vlan_stripping [i40evf]() {
20) | i40evf_send_pf_msg [i40evf]() {
20) | i40e_aq_send_msg_to_pf [i40evf]() {
20) 0.137 us | i40evf_fill_default_direct_cmd_desc [i40evf]();
20) | i40evf_asq_send_command [i40evf]() {
20) | mutex_lock() {
20) | _cond_resched() {
20) 0.144 us | rcu_all_qs();
20) 1.215 us | }
20) 2.350 us | }
20) 0.145 us | i40evf_debug_d [i40evf]();
20) 0.105 us | i40evf_debug_d [i40evf]();
20) 0.148 us | i40evf_debug_aq [i40evf]();
20) 0.112 us | i40evf_debug_d [i40evf]();
20) 0.117 us | i40evf_debug_aq [i40evf]();
20) 0.163 us | mutex_unlock();
20) + 13.471 us | }
20) + 15.886 us | }
20) + 17.167 us | }
20) + 18.831 us | }
22) | i40e_vlan_stripping_enable [i40e]() {
22) | i40e_vlan_stripping_enable.part.86 [i40e]() {
22) | i40e_aq_update_vsi_params [i40e]() {
22) 0.172 us | i40e_fill_default_direct_cmd_desc [i40e]();
22) | i40e_asq_send_command [i40e]() {
22) | mutex_lock() {
22) | _cond_resched() {
22) 0.124 us | rcu_all_qs();
22) 1.183 us | }
22) 2.220 us | }
22) 0.124 us | i40e_debug_aq [i40e]();
22) + 49.861 us | delay_tsc();
22) 0.121 us | i40e_debug_aq [i40e]();
22) 0.113 us | mutex_unlock();
22) + 61.631 us | }
22) + 63.982 us | }
22) + 65.264 us | }
22) + 66.720 us | }

** Affects: linux (Ubuntu)
Importance: Undecided
Status: New

** Information type changed from Public to Private

--
You received this bug notification because you are subscribed to linux
in Ubuntu.
Matching subscriptions: Bgg, Bmail, Nb
https://bugs.launchpad.net/bugs/1807411

Title:
VLAN stripping function will be called after running "ethtool -K rx
off" to change the rx checksum setting

Status in linux package in Ubuntu:
New

Bug description:
check the ftrace ,it shows VLAN stripping setting was changed

Description of problem:
When running "ethtool –K rx off" for VF, the i40evf will also change the VLAN stripping setting unexpectedly.
We tried to create a VF on Ubuntu18.04.1 in-tree i40e driver then ran "ethtool -K rx off" for it with the in-tree i40evf driver. The ftrace showed as below:

i40evf_set_features [i40evf] -----> i40evf_enable_vlan_stripping
[i40evf]-----> i40e_vlan_stripping_enable [i40e].

Version-Release number of selected component (if applicable):
RHEL7.6 Alpha kernel: 3.10.0-924.el7.x86_64
i40e driver: 2.1.14-k
i40evf driver: 3.0.1-k
ethtool version 4.15

repro steps and logs:

root@unassigned-hostname:~# echo i40evf_set_features >> /sys/kernel/debug/tracing/set_graph_function
root@unassigned-hostname:~# echo i40evf_enable_vlan_stripping >> /sys/kernel/debug/tracing/set_graph_function
root@unassigned-hostname:~# echo 20 > /sys/kernel/debug/tracing/max_graph_depth
root@unassigned-hostname:~# echo function_graph > /sys/kernel/debug/tracing/current_tracer
root@unassigned-hostname:~# echo 1 > /sys/kernel/debug/tracing/tracing_on
root@unassigned-hostname:~# cat /sys/kernel/debug/tracing/trace # tracer: function_graph #
# CPU DURATION FUNCTION CALLS
# | | | | | | |
root@unassigned-hostname:~# ethtool -K enp175s2 rx off root@unassigned-hostname:~# cat /sys/kernel/debug/tracing/trace # tracer: function_graph #
# CPU DURATION FUNCTION CALLS
# | | | | | | |
60) 0.254 us | i40evf_set_features [i40evf]();
20) | i40evf_enable_vlan_stripping [i40evf]() {
20) | i40evf_send_pf_msg [i40evf]() {
20) | i40e_aq_send_msg_to_pf [i40evf]() {
20) 0.137 us | i40evf_fill_default_direct_cmd_desc [i40evf]();
20) | i40evf_asq_send_command [i40evf]() {
20) | mutex_lock() {
20) | _cond_resched() {
20) 0.144 us | rcu_all_qs();
20) 1.215 us | }
20) 2.350 us | }
20) 0.145 us | i40evf_debug_d [i40evf]();
20) 0.105 us | i40evf_debug_d [i40evf]();
20) 0.148 us | i40evf_debug_aq [i40evf]();
20) 0.112 us | i40evf_debug_d [i40evf]();
20) 0.117 us | i40evf_debug_aq [i40evf]();
20) 0.163 us | mutex_unlock();
20) + 13.471 us | }
20) + 15.886 us | }
20) + 17.167 us | }
20) + 18.831 us | }
22) | i40e_vlan_stripping_enable [i40e]() {
22) | i40e_vlan_stripping_enable.part.86 [i40e]() {
22) | i40e_aq_update_vsi_params [i40e]() {
22) 0.172 us | i40e_fill_default_direct_cmd_desc [i40e]();
22) | i40e_asq_send_command [i40e]() {
22) | mutex_lock() {
22) | _cond_resched() {
22) 0.124 us | rcu_all_qs();
22) 1.183 us | }
22) 2.220 us | }
22) 0.124 us | i40e_debug_aq [i40e]();
22) + 49.861 us | delay_tsc();
22) 0.121 us | i40e_debug_aq [i40e]();
22) 0.113 us | mutex_unlock();
22) + 61.631 us | }
22) + 63.982 us | }
22) + 65.264 us | }
22) + 66.720 us | }

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1807411/+subscriptions