[Bug 2131265] Re: [SRU] ixgbe: Add support for E610 in Noble

Hi Michael,

Jay and I went through the patchset, and we think its okay. Our previous
comments occurred before we had a chance to read the whole patchset.

That said, you missed the following fixes commits:

b1e44b4 ixgbe: fix media cage present detection for E610 device
4020659 ixgbe: fix media type detection for E610 device
b85936e ixgbe: initialize aci.lock before it's used
316ba68 ixgbe: destroy aci.lock later within ixgbe_remove path

They are all in questing 6.17, and the first two are in plucky's 6.14
kernel.

I think these are valid fixes and should be added to your pull request.

What do you think? If you agree, please do another test build with these
applied, make sure it all works and modify your [Fixes] section, and
resubmit your pull request.

Thanks,
Matthew

--
You received this bug notification because you are subscribed to linux
in Ubuntu.
Matching subscriptions: Bgg, Bmail, Nb
https://bugs.launchpad.net/bugs/2131265

Title:
[SRU] ixgbe: Add support for E610 in Noble

Status in linux package in Ubuntu:
In Progress
Status in linux source package in Noble:
In Progress
Status in linux source package in Plucky:
Fix Released
Status in linux source package in Questing:
Fix Released

Bug description:
[Impact]
Add initial support for Intel(R) E610 Series of network devices. The E610
is based on X550 but adds firmware managed link, enhanced security
capabilities and support for updated server manageability.

Additionally, this is needed for Charmed Openstack Jammy/Caracal
deployment. It requires servers to be on 22.04 Jammy (HWE kernel 6.8).
Some servers f.e. Dell PowerEdge uses Intel NIC E610 and if this nic
is planned to be used for PXE boot and to access the internet this
missing functionality will effectively disqualify those servers from
the approved HW for Openstack since NIC will not be detected by the
OS.

[Fix]

This patch series adds low level support for the following features and
enables link management.

4600cdf ixgbe: Enable link management in E610 device
34b4157 ixgbe: Clean up the E610 link management related code
a0834bd ixgbe: Add ixgbe_x540 multiple header inclusion protection
e5b132b ixgbe: Add support for EEPROM dump in E610 device
d2483eb ixgbe: Add support for NVM handling in E610 device
23c0e5a ixgbe: Add link management support for E610 device
7c3aa0fc ixgbe: Add support for E610 device capabilities detection
46761fd ixgbe: Add support for E610 FW Admin Command Interface

[Test Case]

1. Install the test kernel and reboot
2. Verify the ixgbe module is loaded
   - modinfo ixgbe

3. Remove and Re-add the ixgbe module
   - rmmod ixgbe
   - modprobe ixgbe

3. Verify the Intel E610 is available on the system
    - sudo lshw -C network

4. Configure the ports and ping an external IP address
5. Run Iperf from the SUT to an external iperf server

[Where problems could occur]

The regression risk is low. There are no core kernel changes. Changes
are primarily to the ixgbe driver (drivers/net/ethernet/intel/ixgbe/)
adding support for the Intel E610 device. The majority of the changes
are in newly added files (ixgbe_e610.c ixgbe_type_e610.h). There are
some minor refactoring to existing ixgbe code involving the x540 and
x550 nics but existing device behavior isn't changed it's just shared
with E610.

[Other Info]

Noble
https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/noble/+ref/intel_e610_lp_2131265_2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2131265/+subscriptions